Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update strings when using a custom distribution directory #2689

Merged
merged 1 commit into from Nov 23, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Nov 23, 2021

When using a custom distribution directory goreleaser outputs the commands/information using the default distribution directory ./dist

This PR updates the strings to use the custom name if that is set, to avoid any confusion for the user when reading the logs

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2021
@cpanato cpanato changed the title dist: update strings when using a custom distribution directory chore: update strings when using a custom distribution directory Nov 23, 2021
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2689 (20dfb4c) into main (808b603) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 20dfb4c differs from pull request most recent head d2814fc. Consider uploading reports for the commit d2814fc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         102      102           
  Lines        7790     7790           
=======================================
  Hits         6604     6604           
  Misses        974      974           
  Partials      212      212           
Impacted Files Coverage Δ
internal/pipe/dist/dist.go 90.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808b603...d2814fc. Read the comment docs.

@caarlos0 caarlos0 merged commit ff0fdf3 into goreleaser:main Nov 23, 2021
@caarlos0
Copy link
Member

Thanks!

@caarlos0 caarlos0 added this to the v1.1.0 milestone Nov 23, 2021
@caarlos0 caarlos0 added the bug Something isn't working label Nov 23, 2021
@cpanato cpanato deleted the updatestrings-dist branch November 23, 2021 12:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants