Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checksum extra_files when no builds #2692

Merged
merged 1 commit into from Nov 23, 2021
Merged

fix: checksum extra_files when no builds #2692

merged 1 commit into from Nov 23, 2021

Conversation

caarlos0
Copy link
Member

closes #2691

@caarlos0 caarlos0 added the bug Something isn't working label Nov 23, 2021
@caarlos0 caarlos0 added this to the v1.1.0 milestone Nov 23, 2021
@caarlos0 caarlos0 self-assigned this Nov 23, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Nov 23, 2021
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2021
cpanato
cpanato approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2692 (3474bb2) into main (808b603) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2692   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         102      102           
  Lines        7790     7791    +1     
=======================================
+ Hits         6604     6605    +1     
  Misses        974      974           
  Partials      212      212
Impacted Files Coverage Δ
internal/pipe/checksums/checksums.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808b603...3474bb2. Read the comment docs.

@caarlos0 caarlos0 merged commit 37f8167 into main Nov 23, 2021
@caarlos0 caarlos0 deleted the checksum-fix branch November 23, 2021 12:40
Board automation moved this from In progress to Done Nov 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Board
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

[Bug]: When skipping the build and extraf iels for checksums is not working
2 participants
@caarlos0 @cpanato