Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove docker images from changelog #2708

Merged
merged 1 commit into from
Dec 1, 2021
Merged

feat: remove docker images from changelog #2708

merged 1 commit into from
Dec 1, 2021

Conversation

caarlos0
Copy link
Member

Rationale is in #2707, just opening it here fwiw

closes #2707

refs #2707

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #2708 (ca6c73e) into main (af4a864) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   84.90%   84.88%   -0.03%     
==========================================
  Files         104      104              
  Lines        7886     7873      -13     
==========================================
- Hits         6696     6683      -13     
  Misses        976      976              
  Partials      214      214              
Impacted Files Coverage Δ
internal/pipe/release/body.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4a864...ca6c73e. Read the comment docs.

@caarlos0 caarlos0 marked this pull request as ready for review December 1, 2021 00:13
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 1, 2021
@caarlos0 caarlos0 added this to the v1.2.0 milestone Dec 1, 2021
@caarlos0
Copy link
Member Author

caarlos0 commented Dec 1, 2021

I think this should be ok to merge.

@caarlos0 caarlos0 merged commit 30ff48a into main Dec 1, 2021
@caarlos0 caarlos0 deleted the docker-imgs branch December 1, 2021 00:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] do not automatically list docker images on release notes
1 participant