Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jsonschema build ignore casing #2728

Merged
merged 1 commit into from
Dec 4, 2021
Merged

fix: jsonschema build ignore casing #2728

merged 1 commit into from
Dec 4, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 4, 2021

closes #2727

@caarlos0
fix: jsonschema build ignore casing
988633d 
closes #2727

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2021
@caarlos0 caarlos0 added this to the v1.2.0 milestone Dec 4, 2021
@caarlos0 caarlos0 added bug Something isn't working and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2021
@caarlos0 caarlos0 mentioned this pull request Dec 4, 2021
Closed
3 tasks
@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #2728 (988633d) into main (6774755) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2728   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         105      105           
  Lines        7901     7901           
=======================================
  Hits         6708     6708           
  Misses        978      978           
  Partials      215      215
Impacted Files Coverage Δ
pkg/config/config.go 87.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6774755...988633d. Read the comment docs.

@caarlos0 caarlos0 merged commit 3b620f6 into main Dec 4, 2021
@caarlos0 caarlos0 deleted the schema branch December 4, 2021 15:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

[Bug]: incorrect casing in JSON schema
1 participant
@caarlos0