Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve universal binaries on krew/brew/gofish #2747

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 7, 2021

only use universal binaries on brew/krew/gofish if they replace single-arch ones, otherwise, use the platform-specific ones.

closes #2641

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 7, 2021
@caarlos0 caarlos0 self-assigned this Dec 7, 2021
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #2747 (a54f300) into main (5025a36) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2747   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         105      105           
  Lines        7977     7992   +15     
=======================================
+ Hits         6775     6788   +13     
- Misses        984      986    +2     
  Partials      218      218           
Impacted Files Coverage Δ
internal/artifact/artifact.go 97.69% <50.00%> (-0.90%) ⬇️
internal/pipe/archive/archive.go 94.44% <100.00%> (+0.04%) ⬆️
internal/pipe/brew/brew.go 84.84% <100.00%> (+0.05%) ⬆️
internal/pipe/gofish/gofish.go 77.72% <100.00%> (+0.09%) ⬆️
internal/pipe/krew/krew.go 85.65% <100.00%> (+0.06%) ⬆️
internal/pipe/universalbinary/universalbinary.go 84.41% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5025a36...a54f300. Read the comment docs.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview December 7, 2021 20:31 Inactive
@caarlos0 caarlos0 merged commit e8c8a28 into main Dec 8, 2021
@caarlos0 caarlos0 deleted the unibins branch December 8, 2021 00:53
@github-actions github-actions bot added this to the v1.2.0 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homebrew, gofish et al should handle universal binaries better
1 participant