Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docker): add section for overriding hard-coded image name #2752

Merged
merged 1 commit into from
Dec 21, 2021
Merged

docs(docker): add section for overriding hard-coded image name #2752

merged 1 commit into from
Dec 21, 2021

Conversation

developer-guy
Copy link
Member

@developer-guy developer-guy commented Dec 9, 2021

Co-authored-by: Furkan furkan.turkal@trendyol.com

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Add another section to the Docker's page to tell people how they can override registry and image names within .goreleaser.yml file.

To give information on how they can overcome this issue

...

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #2752 (7604209) into main (8c06005) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #2752    +/-   ##
========================================
  Coverage   84.93%   84.94%            
========================================
  Files         105      106     +1     
  Lines        7992     8235   +243     
========================================
+ Hits         6788     6995   +207     
- Misses        986     1010    +24     
- Partials      218      230    +12     
Impacted Files Coverage Δ
internal/pipe/sign/sign.go 94.39% <0.00%> (-2.49%) ⬇️
cmd/release.go 100.00% <0.00%> (ø)
pkg/config/config.go 87.15% <0.00%> (ø)
pkg/context/context.go 100.00% <0.00%> (ø)
internal/pipe/checksums/checksums.go 100.00% <0.00%> (ø)
internal/pipe/sbom/sbom.go 85.29% <0.00%> (ø)
internal/artifact/artifact.go 97.71% <0.00%> (+0.02%) ⬆️
internal/logext/writer.go 97.05% <0.00%> (+0.08%) ⬆️
main.go 59.09% <0.00%> (+1.94%) ⬆️
internal/gio/hash.go 83.33% <0.00%> (+6.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c06005...7604209. Read the comment docs.

@@ -279,3 +279,52 @@ dockers:
build_flag_templates:
- "--builder=heroku/buildpacks:20"
```

## How to override hardcoded registry and image name ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not so sure if this should be here or in the cookbooks section... thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, if you think that cookbooks page is the right place to put this, then we can move it over there.

@caarlos0
Copy link
Member

lets move it to the cookbooks section @developer-guy ?

@developer-guy
Copy link
Member Author

lets move it to the cookbooks section @developer-guy ?

I already moved it to there 👌

@caarlos0
Copy link
Member

I already moved it to there 👌

oh, my bad, I meant, in a new file here

Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>

Co-authored-by: Furkan Turkal <furkan.turkal@trendyol.com>

Co-authored-by: Furkan Turkal <furkan.turkal@trendyol.com>

Co-authored-by: Furkan <furkan.turkal@trendyol.com>

Co-authored-by: Furkan <furkan.turkal@trendyol.com>

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy
Copy link
Member Author

ah okay, done. 😋

@caarlos0 caarlos0 merged commit cfb2731 into goreleaser:main Dec 21, 2021
@github-actions github-actions bot added this to the v1.2.0 milestone Dec 21, 2021
caarlos0 added a commit that referenced this pull request Dec 21, 2021
refs #2752

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants