-
-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docker): add section for overriding hard-coded image name #2752
docs(docker): add section for overriding hard-coded image name #2752
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2752 +/- ##
========================================
Coverage 84.93% 84.94%
========================================
Files 105 106 +1
Lines 7992 8235 +243
========================================
+ Hits 6788 6995 +207
- Misses 986 1010 +24
- Partials 218 230 +12
Continue to review full report at Codecov.
|
www/docs/customization/docker.md
Outdated
@@ -279,3 +279,52 @@ dockers: | |||
build_flag_templates: | |||
- "--builder=heroku/buildpacks:20" | |||
``` | |||
|
|||
## How to override hardcoded registry and image name ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not so sure if this should be here or in the cookbooks section... thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, if you think that cookbooks page is the right place to put this, then we can move it over there.
lets move it to the cookbooks section @developer-guy ? |
I already moved it to there 👌 |
oh, my bad, I meant, in a new file here |
Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com> Co-authored-by: Furkan Turkal <furkan.turkal@trendyol.com> Co-authored-by: Furkan Turkal <furkan.turkal@trendyol.com> Co-authored-by: Furkan <furkan.turkal@trendyol.com> Co-authored-by: Furkan <furkan.turkal@trendyol.com> Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
ah okay, done. 😋 |
refs #2752 Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Co-authored-by: Furkan furkan.turkal@trendyol.com
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Add another section to the Docker's page to tell people how they can override registry and image names within
.goreleaser.yml
file.To give information on how they can overcome this issue
...