Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: brew service block #2973

Merged
merged 1 commit into from Mar 17, 2022
Merged

feat: brew service block #2973

merged 1 commit into from Mar 17, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 12, 2022

closes #2970

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Mar 12, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 12, 2022
@vercel vercel bot temporarily deployed to Preview March 12, 2022 02:18 Inactive
@caarlos0 caarlos0 added the enhancement New feature or request label Mar 12, 2022
@caarlos0 caarlos0 marked this pull request as ready for review March 12, 2022 02:19
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #2973 (e84f728) into main (42258cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         111      111           
  Lines        9009     9010    +1     
=======================================
+ Hits         7611     7612    +1     
  Misses       1124     1124           
  Partials      274      274           
Impacted Files Coverage Δ
pkg/config/config.go 87.15% <ø> (ø)
internal/pipe/brew/brew.go 84.05% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42258cf...e84f728. Read the comment docs.

@caarlos0 caarlos0 merged commit 7730a4d into main Mar 17, 2022
@caarlos0 caarlos0 deleted the brew-service branch March 17, 2022 00:12
@github-actions github-actions bot added this to the v1.6.0 milestone Mar 17, 2022
@caarlos0 caarlos0 modified the milestones: v1.6.0, v1.7.0 Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Homebrew Service block
1 participant