Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use digest on manifests #3555

Merged
merged 1 commit into from Nov 15, 2022
Merged

feat: use digest on manifests #3555

merged 1 commit into from Nov 15, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 15, 2022

this use the digests on the manifest creation.
Another PR will add it to signing too.

refs #3496
refs #3540

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 15, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2022
@vercel vercel bot temporarily deployed to Preview November 15, 2022 01:18 Inactive
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 15, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 15, 2022 01:19
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #3555 (f47ddd5) into main (ee6225f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3555      +/-   ##
==========================================
+ Coverage   83.66%   83.68%   +0.01%     
==========================================
  Files         116      116              
  Lines        9705     9715      +10     
==========================================
+ Hits         8120     8130      +10     
  Misses       1284     1284              
  Partials      301      301              
Impacted Files Coverage Δ
internal/pipe/docker/manifest.go 96.93% <100.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 4863781 into main Nov 15, 2022
12 checks passed
@caarlos0 caarlos0 deleted the digest branch November 15, 2022 11:21
@github-actions github-actions bot added this to the v1.13.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant