-
-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include prerelease suffix in git #3841
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3841 +/- ##
==========================================
+ Coverage 83.34% 83.36% +0.01%
==========================================
Files 123 123
Lines 10580 10589 +9
==========================================
+ Hits 8818 8827 +9
Misses 1431 1431
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the PR!
I made a couple of comments, let me know what you think!
@caarlos0 thank you for your comments. I don't like my approach with |
awesome, thanks for the work! this will be in goreleaser 1.17, so, by the end of march, if everything goes well. Thanks, again! |
refs #3841 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This commit will fix bad version tag sort if there is a prerelease on the same commit as a release tag. Current output is shown below
Test is changed to match current default value so it will fail without this fix.
Default value
-
is set to the one that is described inside docs, but people are still allowed to change it.Output with fix applied
More info about
versionsort.suffix
can be found hereDocs as well both schemas are updated as well.
I am not sure if users should be allowed to change this option at all.