Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scoop shortcuts #3846

Merged
merged 1 commit into from
Mar 20, 2023
Merged

feat: scoop shortcuts #3846

merged 1 commit into from
Mar 20, 2023

Conversation

howieyuen
Copy link
Contributor

close: #3845

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2023
@howieyuen
Copy link
Contributor Author

@caarlos0

@caarlos0 caarlos0 added this to the v1.17.0 milestone Mar 8, 2023
@caarlos0 caarlos0 added the enhancement New feature or request label Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited

Codecov Report

Merging #3846 (7da65ea) into main (9bdfc55) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7da65ea differs from pull request most recent head 0b773be. Consider uploading reports for the commit 0b773be to get more accurate results

@@           Coverage Diff           @@
##             main    #3846   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files         123      123           
  Lines       10589    10590    +1     
=======================================
+ Hits         8827     8828    +1     
  Misses       1431     1431           
  Partials      331      331
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/pipe/scoop/scoop.go 70.93% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@howieyuen
Copy link
Contributor Author

shall I change the doc to "since 1.17" cause I wrote "1.16.1" ? @caarlos0

@caarlos0
Copy link
Member

shall I change the doc to "since 1.17" cause I wrote "1.16.1" ? @caarlos0

yes, new features go out on minor releases, as per semver

@howieyuen
Copy link
Contributor Author

shall I change the doc to "since 1.17" cause I wrote "1.16.1" ? @caarlos0

yes, new features go out on minor releases, as per semver

ok, I'll make a force push

@caarlos0 caarlos0 merged commit 1f56d8e into goreleaser:main Mar 20, 2023
@howieyuen howieyuen deleted the scoop-shortcuts branch March 20, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

scoop shortcuts support
2 participants
@howieyuen @caarlos0