Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not skip scoop on draft releases #3889

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: do not skip scoop on draft releases #3889

merged 1 commit into from
Mar 24, 2023

Conversation

caarlos0
Copy link
Member

all other pipes don't, not sure why scoop was doing it.

closes #3887

all other pipes don't, not sure why scoop was doing it.

closes #3887
@caarlos0 caarlos0 added the bug Something isn't working label Mar 23, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2023
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 946f554
Status: ✅  Deploy successful!
Preview URL: https://97d76474.goreleaser.pages.dev
Branch Preview URL: https://scoop-draft.goreleaser.pages.dev

View logs

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3889 (946f554) into main (7229a0d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3889      +/-   ##
==========================================
+ Coverage   83.43%   83.44%   +0.01%     
==========================================
  Files         123      123              
  Lines       10635    10643       +8     
==========================================
+ Hits         8873     8881       +8     
  Misses       1431     1431              
  Partials      331      331              
Impacted Files Coverage Δ
internal/pipe/scoop/scoop.go 70.50% <ø> (-0.44%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 723484d into main Mar 24, 2023
@caarlos0 caarlos0 deleted the scoop-draft branch March 24, 2023 03:02
@github-actions github-actions bot added this to the v1.17.0 milestone Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft release is published to brew but not scoop
1 participant