fix(gpg sign): issue #3890 #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
|
I like this, thanks! |
caarlos0
added
bug
|
for some reason github won't let me merge your commit 🤔 |
|
https://www.githubstatus.com/incidents/52z0j6phhnjs oh, ok, that explains it |
caarlos0
referenced
this pull request
Mar 29, 2023
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3890 by checking the user's git
gpg.programconfiguration. If the user didn't set this value it will use the default "gpg", just like before this PR.No need to add a additional unit test as your existing tests cover it (mostly); however, a comment has been added to that check, informing the reader that the test environment assumes
git config gpg.programis not be set.