-
-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to PR homebrew taps #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Apr 4, 2023
caarlos0
added
enhancement
New feature or request
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Apr 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #3903 +/- ##
==========================================
+ Coverage 83.44% 83.84% +0.40%
==========================================
Files 123 123
Lines 10660 10702 +42
==========================================
+ Hits 8895 8973 +78
+ Misses 1433 1389 -44
- Partials 332 340 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Deploying with Cloudflare Pages
|
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Apr 5, 2023
pull-request-size
bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Apr 5, 2023
This was referenced Apr 7, 2023
caarlos0
added a commit
that referenced
this pull request
Apr 7, 2023
following up on #3903 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
that referenced
this pull request
Apr 7, 2023
follow up of #3903 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3485
also fixed a bug in file creation for github: it was always searching for the file in the default branch
also, we don't need to create the file first, update does both create and update.
TODO: implement the for krew, scoop, etc...