Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to PR homebrew taps #3903

Merged
merged 12 commits into from
Apr 7, 2023
Merged

feat: allow to PR homebrew taps #3903

merged 12 commits into from
Apr 7, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 4, 2023

closes #3485

also fixed a bug in file creation for github: it was always searching for the file in the default branch

also, we don't need to create the file first, update does both create and update.

TODO: implement the for krew, scoop, etc...

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 4, 2023
@caarlos0 caarlos0 self-assigned this Apr 4, 2023
@caarlos0 caarlos0 added enhancement New feature or request and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #3903 (30c1438) into main (9dcc63c) will increase coverage by 0.40%.
The diff coverage is 72.82%.

❗ Current head 30c1438 differs from pull request most recent head dcdbb27. Consider uploading reports for the commit dcdbb27 to get more accurate results

@@            Coverage Diff             @@
##             main    #3903      +/-   ##
==========================================
+ Coverage   83.44%   83.84%   +0.40%     
==========================================
  Files         123      123              
  Lines       10660    10702      +42     
==========================================
+ Hits         8895     8973      +78     
+ Misses       1433     1389      -44     
- Partials      332      340       +8     
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/pipe/brew/brew.go 82.51% <57.14%> (-1.25%) ⬇️
internal/client/github.go 54.05% <68.33%> (+15.45%) ⬆️
internal/client/client.go 86.48% <100.00%> (ø)
internal/client/config.go 100.00% <100.00%> (ø)
internal/client/gitea.go 86.66% <100.00%> (ø)
internal/client/gitlab.go 80.24% <100.00%> (ø)
internal/client/mock.go 91.22% <100.00%> (+3.72%) ⬆️
internal/pipe/changelog/changelog.go 92.13% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dcdbb27
Status: ✅  Deploy successful!
Preview URL: https://cbb231c8.goreleaser.pages.dev
Branch Preview URL: https://pr-brw.goreleaser.pages.dev

View logs

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2023
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 5, 2023
@caarlos0 caarlos0 requested a review from radeksimko April 5, 2023 13:19
@caarlos0 caarlos0 merged commit 8b1c4ea into main Apr 7, 2023
10 checks passed
@caarlos0 caarlos0 deleted the pr-brw branch April 7, 2023 01:58
@github-actions github-actions bot added this to the v1.17.0 milestone Apr 7, 2023
caarlos0 added a commit that referenced this pull request Apr 7, 2023
following up on #3903

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
caarlos0 added a commit that referenced this pull request Apr 7, 2023
follow up of #3903

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to PR/MR a homebrew formula
1 participant