fix: use git-archive under the hood #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/L
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Deploying with
|
| Latest commit: |
2e205a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f222792e.goreleaser.pages.dev |
| Branch Preview URL: | https://source-archive-edit.goreleaser.pages.dev |
Codecov Report
@@ Coverage Diff @@
## main #3904 +/- ##
==========================================
- Coverage 83.77% 83.56% -0.22%
==========================================
Files 123 124 +1
Lines 10732 10884 +152
==========================================
+ Hits 8991 9095 +104
- Misses 1397 1433 +36
- Partials 344 356 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts back to using
git archivefor the source archives... but will keep supporting extra files.How it works:
Basically, we run
git archiveas before.Then, we make a backup of the generated archive, and create a new one copying by reading from the backup and writing into the new one.
Finally, we write the extra files to the new one as well.
This only happens if the configuration does have extra files, otherwise, just the simple
git archivewill be run.PS: we can't just append to the archive because weird tar format paddings et al.