Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context info to docker build errors #3920

Merged
merged 1 commit into from
Apr 9, 2023
Merged

feat: add context info to docker build errors #3920

merged 1 commit into from
Apr 9, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Apr 8, 2023

its too hard to debug docker build issues... sometimes is just a typo in the binary name, and you might end debugging it for way too long...

this prints the full path to the build context (so, locally at least, you can cd into it) and also all the files available there when the error seems to be one of the "file not found" kind.

Hopefully this helps fixing things easier :)

closes #3912

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Apr 8, 2023
@caarlos0 caarlos0 self-assigned this Apr 8, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #3920 (8e83af1) into main (8a6de5c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
+ Coverage   83.52%   83.54%   +0.02%     
==========================================
  Files         124      124              
  Lines       10937    10954      +17     
==========================================
+ Hits         9135     9152      +17     
  Misses       1445     1445              
  Partials      357      357              
Impacted Files Coverage Δ
internal/pipe/docker/docker.go 92.41% <100.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit d5a413f into main Apr 9, 2023
12 checks passed
@caarlos0 caarlos0 deleted the docker-err branch April 9, 2023 00:06
@github-actions github-actions bot added this to the v1.17.0 milestone Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker build: eventually binary is not available
1 participant