Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: artifact.Path should filepath.ToSlash #4117

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix: artifact.Path should filepath.ToSlash #4117

merged 1 commit into from
Jun 16, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 16, 2023

this is needed when we run part of the pipeline on windows, and the rest on linux, for example, the split build pro feature.

extracted from #3795

  • added tests for relative path thing

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jun 16, 2023
@caarlos0 caarlos0 self-assigned this Jun 16, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2023
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af058a9
Status: ✅  Deploy successful!
Preview URL: https://9d731876.goreleaser.pages.dev
Branch Preview URL: https://toslash.goreleaser.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #4117 (af058a9) into main (3eecfdd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4117   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files         130      130           
  Lines       12199    12200    +1     
=======================================
+ Hits        10199    10200    +1     
  Misses       1599     1599           
  Partials      401      401           
Impacted Files Coverage Δ
internal/artifact/artifact.go 84.31% <100.00%> (+0.05%) ⬆️

@caarlos0 caarlos0 merged commit ef3c42f into main Jun 16, 2023
12 checks passed
@caarlos0 caarlos0 deleted the toslash branch June 16, 2023 02:43
@github-actions github-actions bot added this to the v1.19.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant