Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nix): description, path and homepage should allow templates #4156

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

caarlos0
Copy link
Member

  • nix.description, nix.path, and nix.homepage should allow templates
  • nix.path was defaulting to wrong value, fixed

@caarlos0 caarlos0 self-assigned this Jun 29, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2023
@caarlos0 caarlos0 added the bug Something isn't working label Jun 29, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b7dd277
Status: ✅  Deploy successful!
Preview URL: https://6ab94fa7.goreleaser.pages.dev
Branch Preview URL: https://nix.goreleaser.pages.dev

View logs

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #4156 (b7dd277) into main (6b46a1a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4156      +/-   ##
==========================================
+ Coverage   84.06%   84.09%   +0.03%     
==========================================
  Files         130      130              
  Lines       12278    12283       +5     
==========================================
+ Hits        10322    10330       +8     
+ Misses       1553     1551       -2     
+ Partials      403      402       -1     
Impacted Files Coverage Δ
internal/pipe/nix/nix.go 81.23% <100.00%> (+1.17%) ⬆️

@caarlos0 caarlos0 merged commit 5f7be84 into main Jun 29, 2023
12 checks passed
@caarlos0 caarlos0 deleted the nix branch June 29, 2023 17:15
@github-actions github-actions bot added this to the v1.20.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant