Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add function to apply template multiple times #4158

Merged
merged 9 commits into from
Jun 30, 2023

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Jun 29, 2023

If applied, this commit simplifies the code required to support templated fields in configuration files. This should make it easier to add more templated fields in the future.

As discussed first on Discord.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #4158 (cbf4d27) into main (5f7be84) will decrease coverage by 0.05%.
The diff coverage is 98.68%.

@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
- Coverage   84.05%   84.00%   -0.05%     
==========================================
  Files         130      130              
  Lines       12266    12191      -75     
==========================================
- Hits        10310    10241      -69     
+ Misses       1554     1550       -4     
+ Partials      402      400       -2     
Impacted Files Coverage Δ
internal/pipe/chocolatey/chocolatey.go 76.31% <87.50%> (+2.17%) ⬆️
internal/archivefiles/archivefiles.go 90.19% <100.00%> (-0.46%) ⬇️
internal/pipe/krew/krew.go 79.92% <100.00%> (-0.84%) ⬇️
internal/pipe/nfpm/nfpm.go 92.87% <100.00%> (-0.17%) ⬇️
internal/pipe/nix/nix.go 80.66% <100.00%> (-0.57%) ⬇️
internal/pipe/scoop/scoop.go 75.09% <100.00%> (-1.22%) ⬇️
internal/pipe/snapcraft/snapcraft.go 83.65% <100.00%> (-0.26%) ⬇️
internal/pipe/winget/winget.go 83.33% <100.00%> (-1.36%) ⬇️
internal/tmpl/tmpl.go 98.33% <100.00%> (+0.08%) ⬆️

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @twpayne 💜

@caarlos0 caarlos0 merged commit c57cdab into goreleaser:main Jun 30, 2023
10 of 11 checks passed
@github-actions github-actions bot added this to the v1.20.0 milestone Jun 30, 2023
@twpayne twpayne deleted the template-apply-all branch July 3, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants