Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(winget): add missing fields, more templates #4164

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix(winget): add missing fields, more templates #4164

merged 1 commit into from
Jul 6, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 6, 2023

This adds missing fields:

  • LicenseURL
  • CopyrightURL
  • Tags

As well as make several more fields templateable.

cc/ @twpayne

This adds missing fields:

- LicenseURL
- CopyrightURL
- Tags

As well as make several more fields templateable.

Co-authored-by: Tom Payne <tom.payne@flarm.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jul 6, 2023
@caarlos0 caarlos0 self-assigned this Jul 6, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4164 (a947b5b) into main (9364d99) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4164   +/-   ##
=======================================
  Coverage   84.00%   84.01%           
=======================================
  Files         130      130           
  Lines       12191    12198    +7     
=======================================
+ Hits        10241    10248    +7     
  Misses       1550     1550           
  Partials      400      400           
Impacted Files Coverage Δ
internal/pipe/winget/template.go 68.96% <ø> (ø)
pkg/config/config.go 88.88% <ø> (ø)
internal/pipe/winget/winget.go 83.72% <100.00%> (+0.38%) ⬆️

@twpayne
Copy link
Contributor

twpayne commented Jul 6, 2023

Looks perfect!

@caarlos0 caarlos0 merged commit a324009 into main Jul 6, 2023
12 checks passed
@caarlos0 caarlos0 deleted the winget branch July 6, 2023 02:33
@github-actions github-actions bot added this to the v1.20.0 milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants