Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: metadata mod_timestamp #4188

Merged
merged 11 commits into from
Jul 15, 2023
Merged

feat: metadata mod_timestamp #4188

merged 11 commits into from
Jul 15, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 14, 2023 •
edited

closes #4167

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 14, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 14, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0cd73cc
Status: ✅  Deploy successful!
Preview URL: https://3793fb2f.goreleaser.pages.dev
Branch Preview URL: https://meta.goreleaser.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 14, 2023 •
edited

Codecov Report

Merging #4188 (9dd55ac) into main (b9a08c4) will decrease coverage by 0.05%.
The diff coverage is 87.50%.

❗ Current head 9dd55ac differs from pull request most recent head 0cd73cc. Consider uploading reports for the commit 0cd73cc to get more accurate results

@@            Coverage Diff             @@
##             main    #4188      +/-   ##
==========================================
- Coverage   84.04%   83.99%   -0.05%     
==========================================
  Files         131      130       -1     
  Lines       12226    12247      +21     
==========================================
+ Hits        10275    10287      +12     
- Misses       1552     1558       +6     
- Partials      399      402       +3
Impacted Files Coverage Δ
pkg/config/config.go 88.88% <ø> (ø)
internal/pipe/metadata/metadata.go 88.46% <83.33%> (-2.97%) ⬇️
internal/pipe/reportsizes/reportsizes.go 88.00% <100.00%> (+2.28%) ⬆️

... and 3 files with indirect coverage changes

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2023
@caarlos0 caarlos0 marked this pull request as ready for review July 14, 2023 17:48
@caarlos0 caarlos0 added the enhancement New feature or request label Jul 14, 2023
@caarlos0 caarlos0 self-assigned this Jul 14, 2023
@caarlos0
test: more tests
9dd55ac
@caarlos0
Merge branch 'main' into meta
23277df
@caarlos0
revert: report_sizes change
28205c1 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
refactor: use the new gio.chtimes fn
538014d 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: commentZZ
75d70f9 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
fix: mkdocs config
0cd73cc
@caarlos0 caarlos0 merged commit 609e7c5 into main Jul 15, 2023
10 of 11 checks passed
@caarlos0 caarlos0 deleted the meta branch July 15, 2023 19:53
@github-actions github-actions bot added this to the v1.20.0 milestone Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

feature request: mod_timestamp for universal_binaries
1 participant
@caarlos0