Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gio.Chtimes #4191

Merged
merged 1 commit into from
Jul 15, 2023
Merged

refactor: gio.Chtimes #4191

merged 1 commit into from
Jul 15, 2023

Conversation

caarlos0
Copy link
Member

we're repeating this quite a bit

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jul 15, 2023
@caarlos0 caarlos0 self-assigned this Jul 15, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2023
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e55ae6f
Status: ✅  Deploy successful!
Preview URL: https://a8490b76.goreleaser.pages.dev
Branch Preview URL: https://chtimes.goreleaser.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #4191 (e55ae6f) into main (3c1ebe8) will increase coverage by 0.04%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main    #4191      +/-   ##
==========================================
+ Coverage   83.99%   84.04%   +0.04%     
==========================================
  Files         130      131       +1     
  Lines       12226    12226              
==========================================
+ Hits        10269    10275       +6     
+ Misses       1556     1552       -4     
+ Partials      401      399       -2     
Impacted Files Coverage Δ
internal/builders/golang/build.go 81.50% <16.66%> (+0.52%) ⬆️
internal/gio/chtimes.go 100.00% <100.00%> (ø)
internal/pipe/universalbinary/universalbinary.go 86.36% <100.00%> (+1.19%) ⬆️

@caarlos0 caarlos0 marked this pull request as ready for review July 15, 2023 19:33
@caarlos0 caarlos0 merged commit b9a08c4 into main Jul 15, 2023
11 of 12 checks passed
@caarlos0 caarlos0 deleted the chtimes branch July 15, 2023 19:33
@github-actions github-actions bot added this to the v1.20.0 milestone Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant