fix(winget): replace forward slashes in Winget RelativeFilePath
#4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
|
ahh good catch, thank you! |
caarlos0
approved these changes
Jul 18, 2023
auto-merge was automatically disabled
July 18, 2023 18:20
Head branch was pushed to by a user without write access
pull-request-size
bot
added
size/M
caarlos0
approved these changes
Jul 18, 2023
caarlos0
changed the title
RelativeFilePathRelativeFilePath
caarlos0
added a commit
that referenced
this pull request
Jul 18, 2023
needs #4195 --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an archive filename contains
/characters, they can sneak into Winget'sRelativeFilePath.In this PR, I make sure that
RelativeFilePathonly uses\directory separators.