Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(winget): improve commit msgs #4199

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(winget): improve commit msgs #4199

merged 1 commit into from
Jul 20, 2023

Conversation

caarlos0
Copy link
Member

closes #4198

@caarlos0 caarlos0 added the enhancement New feature or request label Jul 20, 2023
@caarlos0 caarlos0 self-assigned this Jul 20, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2023
@caarlos0 caarlos0 marked this pull request as ready for review July 20, 2023 00:44
@caarlos0 caarlos0 mentioned this pull request Jul 20, 2023
Closed
3 tasks
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 419c488
Status: ✅  Deploy successful!
Preview URL: https://b99cf9a8.goreleaser.pages.dev
Branch Preview URL: https://winget-commits.goreleaser.pages.dev

View logs

twpayne
twpayne approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #4199 (419c488) into main (e3f494f) will increase coverage by 0.00%.
The diff coverage is 82.60%.

@@           Coverage Diff           @@
##             main    #4199   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         131      131           
  Lines       12266    12285   +19     
=======================================
+ Hits        10315    10331   +16     
- Misses       1552     1555    +3     
  Partials      399      399
Impacted Files Coverage Δ
internal/client/client.go 86.48% <ø> (ø)
internal/pipe/winget/winget.go 83.54% <81.81%> (+0.04%) ⬆️
internal/client/mock.go 91.37% <100.00%> (ø)

@caarlos0 caarlos0 merged commit a726a29 into main Jul 20, 2023
11 of 12 checks passed
@caarlos0 caarlos0 deleted the winget-commits branch July 20, 2023 01:04
@github-actions github-actions bot added this to the v1.20.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

winget: create a single commit for the PR to microsoft/winget-pkgs
2 participants
@caarlos0 @twpayne