Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip defaults for skipped pipes #4210

Merged
merged 4 commits into from
Aug 9, 2023
Merged

fix: skip defaults for skipped pipes #4210

merged 4 commits into from
Aug 9, 2023

Conversation

caarlos0
Copy link
Member

closes #4208

@caarlos0 caarlos0 added the bug Something isn't working label Jul 26, 2023
@caarlos0 caarlos0 self-assigned this Jul 26, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
@caarlos0 caarlos0 marked this pull request as ready for review July 26, 2023 11:18
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 26, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f7b69d0
Status: ✅  Deploy successful!
Preview URL: https://af57a6c9.goreleaser.pages.dev
Branch Preview URL: https://skip-defaulter.goreleaser.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited

Codecov Report

Merging #4210 (8a0e6bb) into main (b242ed0) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 8a0e6bb differs from pull request most recent head f7b69d0. Consider uploading reports for the commit f7b69d0 to get more accurate results

@@            Coverage Diff             @@
##             main    #4210      +/-   ##
==========================================
- Coverage   84.06%   84.06%   -0.01%     
==========================================
  Files         131      131              
  Lines       12405    12303     -102     
==========================================
- Hits        10428    10342      -86     
+ Misses       1575     1562      -13     
+ Partials      402      399       -3
Files Changed Coverage Δ
internal/pipe/defaults/defaults.go 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@caarlos0 caarlos0 mentioned this pull request Jul 26, 2023
Closed
@caarlos0 caarlos0 merged commit dccd68c into main Aug 9, 2023
9 of 11 checks passed
@caarlos0 caarlos0 deleted the skip-defaulter branch August 9, 2023 01:43
@github-actions github-actions bot added this to the v1.20.0 milestone Aug 9, 2023
caarlos0 added a commit that referenced this pull request Aug 9, 2023
@caarlos0
Revert "fix: skip defaults for skipped pipes (#4210)"
08e307e 
This reverts commit dccd68c.

This breaks `continue` on goreleaser-pro.

Will re-work this for the next release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

internal.pipes.defaults.Run() does not check for Skipped defaulters
1 participant
@caarlos0