Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snapcraft): allow to disable #4228

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat(snapcraft): allow to disable #4228

merged 2 commits into from
Aug 3, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 3, 2023

allows to disable a snapcraft configuration based on a template, e.g. if snapshot, nightly, etc

@caarlos0 caarlos0 added the enhancement New feature or request label Aug 3, 2023
@caarlos0 caarlos0 self-assigned this Aug 3, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e1919e
Status: ✅  Deploy successful!
Preview URL: https://1de33b75.goreleaser.pages.dev
Branch Preview URL: https://snapcraft-skip.goreleaser.pages.dev

View logs

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4228 (0e1919e) into main (937aa9e) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4228   +/-   ##
=======================================
  Coverage   84.07%   84.08%           
=======================================
  Files         131      131           
  Lines       12397    12401    +4     
=======================================
+ Hits        10423    10427    +4     
  Misses       1573     1573           
  Partials      401      401           
Files Changed Coverage Δ
pkg/config/config.go 84.94% <ø> (ø)
internal/pipe/snapcraft/snapcraft.go 83.86% <100.00%> (+0.20%) ⬆️

@caarlos0 caarlos0 merged commit d0a86ed into main Aug 3, 2023
12 checks passed
@caarlos0 caarlos0 deleted the snapcraft-skip branch August 3, 2023 12:17
@github-actions github-actions bot added this to the v1.20.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant