Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contributing.md #166

Merged
merged 3 commits into from Jul 10, 2020
Merged

docs: update contributing.md #166

merged 3 commits into from Jul 10, 2020

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 10, 2020

we don't really test on go 1.11, so better don't assume it works.

changed docs to instruct the usage of latest version

also upgraded other deprecated instructions.

closes #127

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jul 10, 2020
@caarlos0 caarlos0 self-assigned this Jul 10, 2020
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2020
@vercel
Copy link

vercel bot commented Jul 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/nwwit3wz4
✅ Preview: https://nfpm-git-contrib.goreleaser.vercel.app

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview July 10, 2020 17:09 Inactive
@caarlos0 caarlos0 merged commit 6ebcf51 into master Jul 10, 2020
@caarlos0 caarlos0 deleted the contrib branch July 10, 2020 17:37
@caarlos0
Copy link
Member Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build on go 1.11.6 (buster's go version)
1 participant