Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Reuse rpm tag constants from rpmutils. #188

Merged

Conversation

erikgeiser
Copy link
Member

This pull request replace the tag constant definitions in the rpm tests with the constants that were already provided by rpmutils. I think that makes sense because they are always used in conjunction with rpm.Header.GetString which is also a rpmutils function. As I see it rpmutils is meant to be used this way.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2020
@vercel
Copy link

vercel bot commented Jul 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/b3volr0bv
✅ Preview: https://nfpm-git-fork-erikgeiser-test-reuse-tags-from-rpmutils.goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview July 31, 2020 18:05 Inactive
@caarlos0 caarlos0 merged commit 3a60553 into goreleaser:master Jul 31, 2020
@caarlos0
Copy link
Member

thanks

@caarlos0
Copy link
Member

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants