Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support DEB Breaks field #220

Merged
merged 3 commits into from Sep 1, 2020

Conversation

erikgeiser
Copy link
Member

This PR adds the Break field and an acceptance test. Closes #219.

@vercel
Copy link

vercel bot commented Sep 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/afq0rp8yt
✅ Preview: https://nfpm-git-fork-erikgeiser-feat-deb-breaks.goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview September 1, 2020 17:28 Inactive
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files           7        7           
  Lines         932      932           
=======================================
  Hits          643      643           
  Misses        179      179           
  Partials      110      110           
Impacted Files Coverage Δ
deb/deb.go 71.04% <ø> (ø)
nfpm.go 79.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59de11a...ace33e2. Read the comment docs.

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to add to the docs as well :)

@vercel vercel bot temporarily deployed to Preview September 1, 2020 18:19 Inactive
@erikgeiser
Copy link
Member Author

Oops, I accidentally auto-formatted the config in the docs. It looks nice through, so I think we should leave it like that.

@caarlos0 caarlos0 added automerge enhancement New feature or request labels Sep 1, 2020
@erikgeiser
Copy link
Member Author

The tests are running out of time again, should I increase the limit to something like 15mins?

@caarlos0
Copy link
Member

caarlos0 commented Sep 1, 2020

The tests are running out of time again, should I increase the limit to something like 15mins?

sounds good

@vercel vercel bot temporarily deployed to Preview September 1, 2020 19:16 Inactive
@kodiakhq kodiakhq bot merged commit fd176b3 into goreleaser:master Sep 1, 2020
@caarlos0
Copy link
Member

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppport "Breaks" deb relationship
2 participants