Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more deprecated things to remove #269

Merged
merged 4 commits into from
Dec 25, 2020
Merged

feat: more deprecated things to remove #269

merged 4 commits into from
Dec 25, 2020

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 23, 2020

removed more deprecated things...

my plan is to roll it in v2.1 (because I forgot about it in v2.0)

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel
Copy link

vercel bot commented Dec 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/i0v68u5mu
✅ Preview: https://nfpm-git-deprecate.goreleaser.now.sh

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 23, 2020
@caarlos0 caarlos0 self-assigned this Dec 23, 2020
@caarlos0 caarlos0 added automerge enhancement New feature or request labels Dec 23, 2020
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview December 23, 2020 20:53 Inactive
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@vercel vercel bot temporarily deployed to Preview December 24, 2020 15:55 Inactive
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview December 25, 2020 13:03 Inactive
@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #269 (831a3b8) into master (bd5888e) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   69.44%   69.82%   +0.37%     
==========================================
  Files           9        9              
  Lines        1103     1097       -6     
==========================================
  Hits          766      766              
+ Misses        209      205       -4     
+ Partials      128      126       -2     
Impacted Files Coverage Δ
nfpm.go 84.78% <ø> (+5.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5888e...831a3b8. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 2770e5b into master Dec 25, 2020
@kodiakhq kodiakhq bot deleted the deprecate branch December 25, 2020 13:15
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge enhancement New feature or request size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants