Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update deps #270

Merged
merged 2 commits into from
Dec 25, 2020
Merged

feat: update deps #270

merged 2 commits into from
Dec 25, 2020

Conversation

caarlos0
Copy link
Member

closes #265

@caarlos0
feat: update deps
4bcd973 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added enhancement New feature or request automerge labels Dec 25, 2020
@caarlos0 caarlos0 self-assigned this Dec 25, 2020
@vercel
Copy link

vercel bot commented Dec 25, 2020 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/c5ws9ohtc
✅ Preview: https://nfpm-git-deps.goreleaser.now.sh

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 25, 2020
@codecov
Copy link

codecov bot commented Dec 25, 2020 •
edited

Codecov Report

Merging #270 (4bcd973) into master (bd5888e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   69.44%   69.44%           
=======================================
  Files           9        9           
  Lines        1103     1103           
=======================================
  Hits          766      766           
  Misses        209      209           
  Partials      128      128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5888e...54fdcf3. Read the comment docs.

djgilcrease
djgilcrease reviewed Dec 25, 2020
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove the replace on rpmpack

@caarlos0
fix: replace
54fdcf3 
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview December 25, 2020 23:19 Inactive
@caarlos0 caarlos0 merged commit d9430e7 into master Dec 25, 2020
@caarlos0 caarlos0 deleted the deps branch December 25, 2020 23:29
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djgilcrease djgilcrease djgilcrease left review comments

Assignees

@caarlos0 caarlos0

Labels
automerge enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signed RPMs failed to install via yum/dnf on RHEL7/CentOS7
2 participants
@caarlos0 @djgilcrease