Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version_schema config option to allow controlling how the version string is parsed. #324

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

djgilcrease
Copy link
Contributor

closes #283

@vercel
Copy link

vercel bot commented Apr 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/A4LHfs93FX5SMwBZ9U9hGjtHNHqk
✅ Preview: https://nfpm-git-allow-multiple-version-schema-goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 22, 2021
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #324 (cc5f1fb) into master (1fb2691) will increase coverage by 0.30%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   69.37%   69.67%   +0.30%     
==========================================
  Files           9        9              
  Lines        1159     1184      +25     
==========================================
+ Hits          804      825      +21     
- Misses        223      225       +2     
- Partials      132      134       +2     
Impacted Files Coverage Δ
rpm/rpm.go 73.20% <60.00%> (-0.67%) ⬇️
apk/apk.go 70.29% <100.00%> (+0.25%) ⬆️
nfpm.go 86.88% <100.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f5bf3...cc5f1fb. Read the comment docs.

@caarlos0
Copy link
Member

can we add tests for it as well?

@djgilcrease djgilcrease force-pushed the allow-multiple-version-schema branch from 4b608ad to f197707 Compare April 23, 2021 00:03
@vercel vercel bot temporarily deployed to Preview April 23, 2021 00:03 Inactive
@djgilcrease djgilcrease force-pushed the allow-multiple-version-schema branch from f197707 to cc5f1fb Compare April 23, 2021 00:05
@vercel vercel bot temporarily deployed to Preview April 23, 2021 00:05 Inactive
@caarlos0 caarlos0 added automerge enhancement New feature or request labels Apr 23, 2021
@kodiakhq kodiakhq bot merged commit fe1413c into master Apr 23, 2021
@kodiakhq kodiakhq bot deleted the allow-multiple-version-schema branch April 23, 2021 00:36
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants