Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jsonschema #350

Merged
merged 5 commits into from
Jul 7, 2021
Merged

feat: jsonschema #350

merged 5 commits into from
Jul 7, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 7, 2021

  • adds a new jsonschema subcommand that generates the jsonschema for nfpm.yml
  • adds some annotations to our structs so the schema is generated somewhat properly
  • adds related docs

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel
Copy link

vercel bot commented Jul 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/5NE97vauMAexvUrSKT5CdroN5Rcq
✅ Preview: https://nfpm-git-schema-goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview July 7, 2021 02:33 Inactive
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #350 (c56520e) into master (a582b89) will decrease coverage by 1.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
- Coverage   66.20%   64.89%   -1.32%     
==========================================
  Files          13       14       +1     
  Lines        1237     1262      +25     
==========================================
  Hits          819      819              
- Misses        284      309      +25     
  Partials      134      134              
Impacted Files Coverage Δ
internal/cmd/root.go 0.00% <0.00%> (ø)
internal/cmd/schema.go 0.00% <0.00%> (ø)
nfpm.go 86.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582b89...c56520e. Read the comment docs.

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview July 7, 2021 02:36 Inactive
@caarlos0 caarlos0 enabled auto-merge (squash) July 7, 2021 02:38
@djgilcrease
Copy link
Contributor

Will look at this tomorrow

Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 5c895f6 into master Jul 7, 2021
@caarlos0 caarlos0 deleted the schema branch July 7, 2021 17:20
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants