Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump most deps #374

Merged
merged 13 commits into from Oct 13, 2021
Merged

feat: bump most deps #374

merged 13 commits into from Oct 13, 2021

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Oct 8, 2021

closes #368

Signed-off-by: Carlos A Becker caarlos0@gmail.com

closes #368
closes #370

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Oct 8, 2021
@caarlos0 caarlos0 self-assigned this Oct 8, 2021
@caarlos0 caarlos0 added this to In progress in Board via automation Oct 8, 2021
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2021
@vercel
Copy link

vercel bot commented Oct 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/6gopbyEXW5jdd41tW9bCw6Kn2cNv
✅ Preview: https://nfpm-git-bump-deps-goreleaser.vercel.app

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 8, 2021

TODO, need to check how to fix this:

=== RUN   TestRPMSignature
    rpm_test.go:663: 
                Error Trace:    rpm_test.go:663
                Error:          Received unexpected error:
                                openpgp: unsupported feature: unknown critical signature subpacket type 33
                Test:           TestRPMSignature

Board automation moved this from In progress to Reviewer approved Oct 8, 2021
@erikgeiser
Copy link
Member

Signature difference compared to master:

$ gpg --list-packets newsig.gpg
# off=0 ctb=c2 tag=2 hlen=3 plen=307 new-ctb
:signature packet: algo 1, keyid 9890904DFB2EC88A
	version 4, created 1633722953, md5len 0, sigclass 0x00
	digest algo 8, begin of digest 4c e5
	hashed subpkt 2 len 4 (sig created 2021-10-08)
	critical hashed subpkt 16 len 8 (issuer key ID 9890904DFB2EC88A)
	critical hashed subpkt 33 len 21 (issuer fpr v4 17C3B663E404B3CB3033271A9890904DFB2EC88A)
	data: [2047 bits]

$ gpg --list-packets oldsig.gpg
# off=0 ctb=c2 tag=2 hlen=3 plen=307 new-ctb
:signature packet: algo 1, keyid 9890904DFB2EC88A
	version 4, created 1633723003, md5len 0, sigclass 0x00
	digest algo 8, begin of digest e9 77
	hashed subpkt 2 len 4 (sig created 2021-10-08)
	hashed subpkt 16 len 8 (issuer key ID 9890904DFB2EC88A)
	hashed subpkt 33 len 21 (issuer fpr v4 17C3B663E404B3CB3033271A9890904DFB2EC88A)
	data: [2048 bits]

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 8, 2021

its coming from protonmail openpgpg's lib

diffs:

@caarlos0
Copy link
Member Author

caarlos0 commented Oct 8, 2021

my bet: ProtonMail/go-crypto@cc34b1f

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2021
@vercel vercel bot temporarily deployed to Preview October 8, 2021 20:55 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview October 8, 2021 20:56 Inactive
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #374 (5023726) into master (6b039bd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files          14       14           
  Lines        1290     1290           
=======================================
  Hits          841      841           
  Misses        313      313           
  Partials      136      136           
Impacted Files Coverage Δ
rpm/rpm.go 73.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b039bd...5023726. Read the comment docs.

Base automatically changed from go117 to master October 10, 2021 13:28
@vercel vercel bot temporarily deployed to Preview October 10, 2021 14:00 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview October 10, 2021 14:01 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview October 12, 2021 17:36 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview October 12, 2021 17:36 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2021
@vercel vercel bot temporarily deployed to Preview October 12, 2021 17:40 Inactive
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@pull-request-size pull-request-size bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 12, 2021
@vercel vercel bot temporarily deployed to Preview October 12, 2021 17:43 Inactive
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2021
@caarlos0 caarlos0 changed the title feat: bump all deps feat: bump most deps Oct 12, 2021
@caarlos0
Copy link
Member Author

for now will leave openpgp on the current version, just so I can release the other stuff

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview October 12, 2021 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2021 19:55 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2021 23:52 Inactive
@caarlos0 caarlos0 merged commit 8230209 into master Oct 13, 2021
@caarlos0 caarlos0 deleted the bump-deps branch October 13, 2021 00:01
Board automation moved this from Reviewer approved to Done Oct 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Board
Done
Development

Successfully merging this pull request may close these issues.

Security: CVE-2020-7667
2 participants