Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info.Validate is called twice #393

Closed
erikgeiser opened this issue Nov 4, 2021 · 1 comment
Closed

info.Validate is called twice #393

erikgeiser opened this issue Nov 4, 2021 · 1 comment

Comments

@erikgeiser
Copy link
Member

Currently info.Validate is called twice, once after parsing the config and once in each packager. Unfortunately this is somewhat costly for large packages due to file stat'ing and sorting.

We could either remove one of the calls or add an internal variable to keep track if it was already called and make it a no-op in this case.

If we decide on a solution I can add it to #388 as it is kind of related.

@djgilcrease
Copy link
Contributor

I would leave only the one in the packagers

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants