Fix: Allow complex file modes for debs and apks. #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 64.66% 64.70% +0.03%
==========================================
Files 14 14
Lines 1834 1836 +2
==========================================
+ Hits 1186 1188 +2
Misses 512 512
Partials 136 136
Continue to review full report at Codecov.
|
|
noice, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs fixes #392 by passing the full file mode instead of just the permissions (which is the mode masked with
0o777) to thetarheader. It also added acceptance tests with suid bit for all packagers and documentation that reminds users to specify the mode in octal.