Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lintian issues #445

Merged
merged 4 commits into from
Feb 3, 2022
Merged

fix: lintian issues #445

merged 4 commits into from
Feb 3, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 3, 2022

refs #439

this fixes some of lintian's issues with nfpm package itself.

@caarlos0
fix: lintian issues
30b0eec 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
fix: merge
a3aa228 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0
docs: mention lintian
ab54928 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 added the bug Something isn't working label Feb 3, 2022
@caarlos0 caarlos0 self-assigned this Feb 3, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #445 (1669729) into main (00413e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   65.86%   65.86%           
=======================================
  Files          16       16           
  Lines        1901     1901           
=======================================
  Hits         1252     1252           
  Misses        510      510           
  Partials      139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00413e3...1669729. Read the comment docs.

@caarlos0
fix: overrides
1669729 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview February 3, 2022 03:22 Inactive
@caarlos0 caarlos0 merged commit 1f50ccc into main Feb 3, 2022
@caarlos0 caarlos0 deleted the lintian branch February 3, 2022 12:20
@github-actions github-actions bot added this to the 2.12.0 milestone Feb 3, 2022
caarlos0 added a commit that referenced this pull request Feb 9, 2022
@caarlos0
fix: docker image entrypoint
aba336a 
changed the bindir on #445, forgot to change it in the dockerfile as well

closes #452

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@caarlos0