-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for build rpm packages for aarch64 #56
Conversation
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 71.39% 71.57% +0.17%
==========================================
Files 5 5
Lines 493 496 +3
==========================================
+ Hits 352 355 +3
Misses 87 87
Partials 54 54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good... can you add a test for it?
@caarlos0 Of course, I was not sure what you would need. Is there any prior art that I should follow? |
there is an acceptance folder with some tests for both rpm and deb... I'm not sure we can simulate this with docker, but in case we do that's the "real tests" for the Thanks for the contribution! |
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
aebd56b
to
cfa5616
Compare
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@caarlos0 I apologize it took so long. I added acceptance tests for arm64 (deb + rpm) |
awesome, thanks! |
Thank you @caarlos0 What is required to get this feature into goreleaser? |
release here and go mod update there... let me cut a tag here first :D |
* add support for build rpm packages for aarch64 Signed-off-by: Christoph Hartmann <chris@lollyrock.com> * add unit test to verify the manipulation of the arch field Signed-off-by: Christoph Hartmann <chris@lollyrock.com> * add acceptance test for arm64 builds Signed-off-by: Christoph Hartmann <chris@lollyrock.com> * use newer travis ubuntu distro Signed-off-by: Christoph Hartmann <chris@lollyrock.com> * enable binfmt in docker Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Signed-off-by: Christoph Hartmann chris@lollyrock.com
Rhel/Fedora use
aarch64
instead ofarm64
.Reference: