Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for build rpm packages for aarch64 #56

Merged
merged 5 commits into from
Jun 28, 2019

Conversation

chris-rock
Copy link
Contributor

Signed-off-by: Christoph Hartmann chris@lollyrock.com

Rhel/Fedora use aarch64 instead of arm64.

Reference:

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #56 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   71.39%   71.57%   +0.17%     
==========================================
  Files           5        5              
  Lines         493      496       +3     
==========================================
+ Hits          352      355       +3     
  Misses         87       87              
  Partials       54       54
Impacted Files Coverage Δ
rpm/rpm.go 73.09% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cf0f6...09976eb. Read the comment docs.

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good... can you add a test for it?

@chris-rock
Copy link
Contributor Author

@caarlos0 Of course, I was not sure what you would need. Is there any prior art that I should follow?

@caarlos0
Copy link
Member

@caarlos0 Of course, I was not sure what you would need. Is there any prior art that I should follow?

there is an acceptance folder with some tests for both rpm and deb... I'm not sure we can simulate this with docker, but in case we do that's the "real tests"

for the archToRPM specifically I think there are some tests on rpm_test.go

Thanks for the contribution!

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
Copy link
Contributor Author

@caarlos0 I apologize it took so long. I added acceptance tests for arm64 (deb + rpm)

@caarlos0
Copy link
Member

awesome, thanks!

@caarlos0 caarlos0 merged commit 7939798 into goreleaser:master Jun 28, 2019
@chris-rock
Copy link
Contributor Author

Thank you @caarlos0 What is required to get this feature into goreleaser?

@caarlos0
Copy link
Member

release here and go mod update there...

let me cut a tag here first :D

AdrianWennberg pushed a commit to AdrianWennberg/nfpm that referenced this pull request Aug 22, 2019
* add support for build rpm packages for aarch64

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

* add unit test to verify the manipulation of the arch field

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

* add acceptance test for arm64 builds

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

* use newer travis ubuntu distro

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

* enable binfmt in docker

Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@caarlos0
Copy link
Member

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants