Adding Prefix and Group tags #59
Conversation
Our build system has a complex rmpbuld environment set up where macros don't match with the defaults that nfpm exepcts. This change will enforce those defaults which makes nfpm less dependant on the build environment.
These tags are only implemented for RPMs because there is no good parallel to draw to deb tags. See goreleaser#57
|
any thing like this for deb? if its only for RPM, maybe prefix the config with |
|
The For reference: Putting the new tags into an |
|
Yeah seems good to me! And the deb specific ones we can put under a Deb block too.. willing to make this change? |
|
Moving the Other that that, I'd be happy to make the change! |
|
Oops forgot to actually create the package in the test. |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 71.57% 71.68% +0.11%
==========================================
Files 5 5
Lines 496 498 +2
==========================================
+ Hits 355 357 +2
Misses 87 87
Partials 54 54
Continue to review full report at Codecov.
|
|
Hey Carlos, I think this is merge ready now. Give me a shout if there is anything else you would like me to add. |
| Group: "default", | ||
| Prefix: "/usr", | ||
| } | ||
| var err = Default.Package(info, ioutil.Discard) |
There was a problem hiding this comment.
maybe write to a file and compare with the expected result? (like goldenfiles above)
There was a problem hiding this comment.
I added a new commit. Does that look good to you?
|
thank you very much for the PR and all the effort :) ✨ |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Prefix and Group tags added for RPMs only since those tags do not exist for deb packages.
Also defined some macros for rpmbuild to make nfpm less dependent on the build environment.