Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not encourage using /usr/local/bin #596

Merged
merged 2 commits into from
Dec 30, 2022
Merged

fix: do not encourage using /usr/local/bin #596

merged 2 commits into from
Dec 30, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 30, 2022

Examples, tests and docs often refer to /usr/local/bin, which should only be used for things compiled locally, which is not the case of installed packages.

Changed that to /usr/bin, and also some usages of things like /usr/something to /usr/share/something.

Examples, tests and docs often refer to /usr/local/bin, which should
only be used for things compiled locally, which is not the case of
installed packages.

Changed that to /usr/bin, and also some usages of things like
/usr/something to /usr/share/something.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Dec 30, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2022
@caarlos0 caarlos0 added enhancement New feature or request and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2022
@cloudflare-pages
Copy link

cloudflare-pages bot commented Dec 30, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f415890
Status: ✅  Deploy successful!
Preview URL: https://1f386337.nfpm.pages.dev
Branch Preview URL: https://local.nfpm.pages.dev

View logs

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #596 (f415890) into main (0c2ef6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   70.41%   70.41%           
=======================================
  Files          21       21           
  Lines        3150     3150           
=======================================
  Hits         2218     2218           
  Misses        715      715           
  Partials      217      217           
Impacted Files Coverage Δ
internal/cmd/init.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit dedee6d into main Dec 30, 2022
@caarlos0 caarlos0 deleted the local branch December 30, 2022 01:19
@github-actions github-actions bot added this to the v2.23.0 milestone Dec 30, 2022
caarlos0 added a commit that referenced this pull request Dec 30, 2022
refs #596 (comment)

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants