Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rules tests, overridables #66

Merged
merged 4 commits into from Aug 31, 2019
Merged

fix: rules tests, overridables #66

merged 4 commits into from Aug 31, 2019

Conversation

caarlos0
Copy link
Member

improved #49 and moved RPM to overridables.

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 merged commit 33156b2 into master Aug 31, 2019
@caarlos0 caarlos0 deleted the overridables branch August 31, 2019 13:21
@codecov-io
Copy link

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   71.74%   71.74%           
=======================================
  Files           5        5           
  Lines         499      499           
=======================================
  Hits          358      358           
  Misses         87       87           
  Partials       54       54
Impacted Files Coverage Δ
rpm/rpm.go 73.41% <ø> (ø) ⬆️
nfpm.go 89.65% <ø> (ø) ⬆️
deb/deb.go 72.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8350598...c747469. Read the comment docs.

@caarlos0
Copy link
Member Author

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants