Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use goversion lib #685

Merged
merged 3 commits into from Jun 27, 2023
Merged

fix: use goversion lib #685

merged 3 commits into from Jun 27, 2023

Conversation

caarlos0
Copy link
Member

refs #684

uses the same version lib goreleaser uses.

@caarlos0
feat: use goversion lib
7074ee5 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jun 27, 2023
@caarlos0 caarlos0 self-assigned this Jun 27, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2023
@caarlos0
Merge remote-tracking branch 'origin/main' into version
146c8b9 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 27, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 526d5e5
Status: ✅  Deploy successful!
Preview URL: https://ef35996c.nfpm.pages.dev
Branch Preview URL: https://version.nfpm.pages.dev

View logs

@caarlos0
Copy link
Member Author

Output will look like this:

       _____ ____  __  __ 
 _ __ |  ___|  _ \|  \/  |
| '_ \| |_  | |_) | |\/| |
| | | |  _| |  __/| |  | |
|_| |_|_|   |_|   |_|  |_|
                          
nfpm: a simple and 0-dependencies deb, rpm, apk and arch linux packager written in Go
https://nfpm.goreleaser.com

GitVersion:    dev
GitCommit:     unknown
GitTreeState:  unknown
BuildDate:     unknown
BuiltBy:       unknown
GoVersion:     go1.20.5
Compiler:      gc
ModuleSum:     unknown
Platform:      linux/amd64

With more info when not a dev version of course :)

@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited

Codecov Report

Merging #685 (526d5e5) into main (4afeb94) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files          14       14           
  Lines        2962     2962           
=======================================
  Hits         2247     2247           
  Misses        506      506           
  Partials      209      209

@caarlos0
fix: trailing empty line
526d5e5 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit f8c8ab0 into main Jun 27, 2023
40 checks passed
@caarlos0 caarlos0 deleted the version branch June 27, 2023 13:31
@github-actions github-actions bot added this to the v2.27.0 milestone Jun 27, 2023
@caarlos0 caarlos0 modified the milestones: v2.27.0, 2.32.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@caarlos0