build fat-mach-o binary for pygore #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TcM1911
requested changes
Feb 14, 2023
revert setting ARCH parameter, delete $(ARCH) from DARWIN_GO_ENV
TcM1911
approved these changes
Apr 14, 2023
|
@TcM1911 - Hi, just checking by to see if this will be released as a patch version? Would be cool if PyGoRE would be updated as well so users can enjoy this library on their Apple silicon MBPs with a simple pip install 😁. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with pygore where the pip pygore package comes with amd64 compiled
libgore.dyliband lacks support for Applie Silicon arm64 architecture.The Makefile was changed to compile both an amd64 and an arm64 version and create a fat-mach-o universal
libgore.dylibbinary.Tested to work on my MBP M1 14"