Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

part 2 of graphite testing #34

Open
wants to merge 2 commits into
base: 04-20-graphite_test_part_1
Choose a base branch
from
Open

part 2 of graphite testing #34

wants to merge 2 commits into from

Conversation

goretkin
Copy link
Owner

No description provided.

@goretkin goretkin mentioned this pull request Apr 20, 2023
Open
@goretkin
Copy link
Owner Author

goretkin commented Apr 20, 2023 •
edited

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @goretkin and the rest of your teammates on Graphite Graphite

@goretkin goretkin mentioned this pull request Apr 20, 2023
Open
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c69ad3) 85.94% compared to head (8150c3f) 85.94%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@                     Coverage Diff                     @@
##           04-20-graphite_test_part_1      #34   +/-   ##
===========================================================
  Coverage                       85.94%   85.94%           
===========================================================
  Files                               9        9           
  Lines                             370      370           
===========================================================
  Hits                              318      318           
  Misses                             52       52

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goretkin goretkin mentioned this pull request Apr 20, 2023
Open
@ggoretkin-bdai
part 5 of graphite testing, modifying the contents of a file made in …
8150c3f 
…part 1 but doing this at part-2 section of the stack
jiuguangw
jiuguangw reviewed Apr 20, 2023
View reviewed changes
Copy link

@jiuguangw jiuguangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

test-garbage-file1.txt
@@ -0,0 +1,9 @@
I made a mistake at part 4.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment

@goretkin
Copy link
Owner Author

goretkin commented Apr 20, 2023 •
edited

I believe that after I made a change to this "layer"? of the stack, at this commit: 8150c3f that the subsequent layers were rebased.

Indeed:
image

https://github.com/goretkin/FixArgs.jl/compare/feb35ab371be30dcb3a8f3b03519b1e6d5c02654..88b21d71a8174afa21ea90929a4394abb0faeb23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiuguangw jiuguangw jiuguangw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goretkin @codecov-commenter @jiuguangw @ggoretkin-bdai