Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework errors #46

Closed
chewxy opened this issue Oct 11, 2016 · 8 comments
Closed

Rework errors #46

chewxy opened this issue Oct 11, 2016 · 8 comments
Assignees
@NDari
Labels
enhancement error handling

Comments

@chewxy
Copy link
Member

chewxy commented Oct 11, 2016 •
edited

This task is broken into two parts:

  • Wrap all errors in Gorgonia with the errors package, with meaningful error messages.
  • Remove all of the runtime.Caller() function from the basic errors.
@ghost
Copy link

ghost commented Oct 12, 2016

i'd like to take a shot at this

@chewxy
Copy link
Member Author

chewxy commented Oct 12, 2016

Added you to the list of collaborators. It's just so I can assign the issue. Please use a personal fork and send a pull request

@ghost
Copy link

ghost commented Oct 12, 2016

Awesome, will do. Thanks 😃

@chewxy chewxy assigned ghost Oct 12, 2016
@ghost ghost removed their assignment Oct 25, 2016
@ghost
Copy link

ghost commented Oct 25, 2016

I haven't had time to wrap my head around this. I'll keep looking back to it but if anyone else wants to take it on please do.

@chewxy
Copy link
Member Author

chewxy commented Oct 27, 2016

Cool. thank you Rob

@NDari NDari mentioned this issue Nov 4, 2016
Merged
@NDari
Copy link
Collaborator

NDari commented Nov 4, 2016

I have started work on this Issue. The WIP is in the PR above.

@chewxy
Copy link
Member Author

chewxy commented Nov 4, 2016

Thank you. I'll add you to the list of assignees

chewxy added a commit that referenced this issue Nov 13, 2016
@chewxy
Merge pull request #59 from NDari/errors
0c36085 
Gorgonia uses the errors package now. #46 fixed for the most part.
@chewxy
Copy link
Member Author

chewxy commented Nov 28, 2016

This should have been closed.

@chewxy chewxy closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NDari NDari

Labels
enhancement error handling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chewxy @NDari