Clean up language in the code #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In anticipation of 1.0, some of the lively language in the comments were toned down a wee bit.
|
Hey Naseer
I'll merge this when I get back
…On Sat, May 13, 2017 at 12:54 PM, Naseer Dari ***@***.***> wrote:
In anticipation of 1.0, some of the lively language in the comments were
toned down a wee bit.
------------------------------
You can view, comment on, or merge this pull request online at:
#115
Commit Summary
- Clean up language in the code
File Changes
- *M* blase/fn.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-0> (2)
- *M* cmd/cudagen/main.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-1> (1)
- *M* node.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-2> (2)
- *M* tensor/dense_svd_test.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-3> (2)
- *M* tensor/tensor.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-4> (4)
- *M* typeSystem_test.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-5> (4)
- *M* vm_genera_test.go
<https://github.com/chewxy/gorgonia/pull/115/files#diff-6> (2)
Patch Links:
- https://github.com/chewxy/gorgonia/pull/115.patch
- https://github.com/chewxy/gorgonia/pull/115.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#115>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAczUptBz0xlB6JMLxFIOJCic08bQvxjks5r5Rt7gaJpZM4NZ8L_>
.
|
|
No worries! Enjoy whatever shenanigans you are doing!
… On May 12, 2017, at 9:59 PM, Chewxy ***@***.***> wrote:
Hey Naseer
I'll merge this when I get back
*Xuanyi Chew*
***@***.*** on Twitter*
*Read:* my blog <http://blog.chewxy.com>
*+61403928398*
On Sat, May 13, 2017 at 12:54 PM, Naseer Dari ***@***.***>
wrote:
> In anticipation of 1.0, some of the lively language in the comments were
> toned down a wee bit.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #115
> Commit Summary
>
> - Clean up language in the code
>
> File Changes
>
> - *M* blase/fn.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-0> (2)
> - *M* cmd/cudagen/main.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-1> (1)
> - *M* node.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-2> (2)
> - *M* tensor/dense_svd_test.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-3> (2)
> - *M* tensor/tensor.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-4> (4)
> - *M* typeSystem_test.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-5> (4)
> - *M* vm_genera_test.go
> <https://github.com/chewxy/gorgonia/pull/115/files#diff-6> (2)
>
> Patch Links:
>
> - https://github.com/chewxy/gorgonia/pull/115.patch
> - https://github.com/chewxy/gorgonia/pull/115.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#115>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAczUptBz0xlB6JMLxFIOJCic08bQvxjks5r5Rt7gaJpZM4NZ8L_>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#115 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJLtxjS9o6wODCU10DoOUPy-HDeQWn6Gks5r5RyagaJpZM4NZ8L_>.
|
|
Holy shit my email signature was on the comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In anticipation of 1.0, some of the lively language in the comments were
toned down a wee bit.