Softmax op #440
Merged
Softmax op #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's still missing the methods to allow to back propagate it
chewxy
reviewed
Oct 12, 2020
op_softmax.go
Outdated
| sm.Reshape(inputTensor.Shape().TotalSize(), 1) | ||
|
|
||
| smT := sm.Clone().(tensor.Tensor) | ||
| smT.Transpose() |
There was a problem hiding this comment.
you can use smT.T(), which does no work, rather than Transpose which does a lot of work
op_softmax.go
Outdated
| smT := sm.Clone().(tensor.Tensor) | ||
| smT.Transpose() | ||
|
|
||
| smDot, err := tensor.Dot(sm, smT) |
There was a problem hiding this comment.
Use MatMul. tensor.Dot is a bad habit
And handle the errors properly
And add debugging statements
Co-authored-by: David Cuadrado <73729+dcu@users.noreply.github.com>
Updated softmax test to also check for values Co-authored-by: David Cuadrado <73729+dcu@users.noreply.github.com>
Co-authored-by: David Cuadrado <73729+dcu@users.noreply.github.com>
|
Phew. This LGTM. Once it passes tests, you can merge. Most excellent work @dcu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.