Implement Softmax and LogSoftMax #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcu
force-pushed
the
log-softmax
branch
2 times, most recently
from
655584f
to
f7bcdc4
Compare
chewxy
requested changes
Oct 15, 2021
|
|
||
| for ii := 0; ii < innerSize*outerSize; ii++ { | ||
| outerIndex := ii / innerSize | ||
| innerIndex := ii % innerSize |
There was a problem hiding this comment.
Can we use this for all divmod: https://github.com/gorgonia/tensor/blob/master/mathutils.go
| @@ -422,3 +422,8 @@ type denseArgmaxer interface { | |||
| type denseArgminer interface { | |||
| argminDenseTensor(t DenseTensor, axis int) (*Dense, error) | |||
| } | |||
|
|
|||
| type softMaxer interface { | |||
|
|
||
| for ii := 0; ii < innerSize*outerSize; ii++ { | ||
| outerIndex := ii / innerSize | ||
| innerIndex := ii % innerSize |
There was a problem hiding this comment.
Use divmod from https://github.com/gorgonia/tensor/blob/master/mathutils.go
|
#119 supercedes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backwards operations will be send in a different PR