Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assembly calls to runtime.panicindex for Go 1.12 #5

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Remove assembly calls to runtime.panicindex for Go 1.12 #5

merged 1 commit into from
Jan 14, 2019

Conversation

aclements
Copy link
Contributor

Go 1.12 does not allow the unexported function runtime.panicindex to
be called from assembly code in other packages. Fix this by wrapping
the assembly functions that call panicindex in Go functions and
lifting these checks into the Go functions. The Go wrapper functions
are inlined (as of Go 1.12), so there's no additional cost to doing
this.

Fixes #4.

Go 1.12 does not allow the unexported function runtime.panicindex to
be called from assembly code in other packages. Fix this by wrapping
the assembly functions that call panicindex in Go functions and
lifting these checks into the Go functions. The Go wrapper functions
are inlined (as of Go 1.12), so there's no additional cost to doing
this.

Fixes #4.
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 91.579% when pulling 89e245d on aclements:master into 8f2bcc9 on gorgonia:master.

@chewxy chewxy merged commit 3ad6354 into gorgonia:master Jan 14, 2019
@chewxy
Copy link
Member

chewxy commented Jan 14, 2019

Thank you!
p/s: I fixed github.com/gorgonia/vecf32 and added you to both contributors list (for this repo and vecf32)

Thanks once more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants