Run docs/test.html tests on Node.js #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjethani
commented
Sep 5, 2021
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
There's more to this integration. For example, when I open a pull request, it should run the tests on the pull request. I'll look into this a little later.
mjethani
commented
Sep 5, 2021
| } | ||
|
|
||
| const resultTemplateGood = ' Success: checkPublicSuffix({{a}}, {{b}})'; | ||
| const resultTemplateBad = '\u2757 Failure: got {{r}} instead: checkPublicSuffix({{a}}, {{b}})'; |
There was a problem hiding this comment.
Showing "❗️" in case of failure.
mjethani
commented
Sep 5, 2021
| checkAll(); | ||
| console.log(); | ||
|
|
||
| console.log(`Finished with ${errorCount} errors ${errorCount === 0 ? '\ud83c\udf89' : '\u2620\ufe0f'}`); |
There was a problem hiding this comment.
Showing "🎉" and "☠️" in the cases of success and failure respectively.
mjethani
commented
Sep 5, 2021
| console.log(); | ||
|
|
||
| if ( errorCount > 0 ) { | ||
| process.exit(1); |
There was a problem hiding this comment.
Non-zero exit code in case of any failures.
mjethani
commented
Sep 5, 2021
| } | ||
| } | ||
|
|
||
| // This function is a verbatim copy of the one in docs/test.html |
There was a problem hiding this comment.
This is an exact copy of the code in docs/test.html. It should be easy to keep them in sync. In the end I expect that this file will become redundant as we have better tests in tests/*.js eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings the tests in
docs/test.htmlto Node.js.There's a
tests.ymlfile that runs the tests on GitHub.README.mdincludes a badge and brief development instructions.More in inline comments.