Fix regression in handling of experimental header= filter option

Also completed fix for reverse lookup issues related to `header=` filter option: uBlockOrigin/uBlock-issues#1932
gorhill · Jul 14, 2023 · aa6baf9 · aa6baf9
1 parent 0da7e12
commit aa6baf9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/js/1p-filters.js b/src/js/1p-filters.js
@@ -70,7 +70,9 @@ let cachedUserFilters = '';
         if ( response instanceof Object === false ) { return; }
         if ( response.hintUpdateToken !== undefined ) {
             const mode = cmEditor.getMode();
-            cmEditor.setOption('filterOnHeaders', response.filterOnHeaders === true);
+            if ( typeof response.filterOnHeaders === 'boolean' ) {
+                cmEditor.setOption('filterOnHeaders', response.filterOnHeaders);
+            }
             if ( mode.setHints instanceof Function ) {
                 mode.setHints(response);
             }

diff --git a/src/js/reverselookup.js b/src/js/reverselookup.js
@@ -131,8 +131,9 @@ const fromNetFilter = async function(rawFilter) {
     const writer = new CompiledListWriter();
     const parser = new sfp.AstFilterParser({
         expertMode: true,
-        nativeCssHas: vAPI.webextFlavor.env.includes('native_css_has'),
+        filterOnHeaders: true,
         maxTokenLength: staticNetFilteringEngine.MAX_TOKEN_LENGTH,
+        nativeCssHas: vAPI.webextFlavor.env.includes('native_css_has'),
     });
     parser.parse(rawFilter);
 

diff --git a/src/js/storage.js b/src/js/storage.js
@@ -1051,8 +1051,9 @@ self.addEventListener('hiddenSettingsChanged', ( ) => {
         this.hiddenSettings.filterAuthorMode !== false;
     const parser = new sfp.AstFilterParser({
         expertMode,
-        nativeCssHas: vAPI.webextFlavor.env.includes('native_css_has'),
+        filterOnHeaders: µb.hiddenSettings.filterOnHeaders,
         maxTokenLength: staticNetFilteringEngine.MAX_TOKEN_LENGTH,
+        nativeCssHas: vAPI.webextFlavor.env.includes('native_css_has'),
     });
     const compiler = staticNetFilteringEngine.createCompiler(parser);
     const lineIter = new LineIterator(